-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove skeleton motion #4462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove skeleton motion #4462
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4cc705b
Remove skeleton motion
0743aa3
Remove keyframes, add PR number
53f519b
Update UNRELEASED-v7.md
14ead65
Merge branch 'main' into rm-skeleton-motion
alex-page 6f077f0
Update UNRELEASED.md
alex-page 476fa7c
Merge branch 'v8.0.0-major' into rm-skeleton-motion
alex-page acf418a
Update UNRELEASED.md
alex-page 9ccae5c
Update UNRELEASED.md
alex-page File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,6 @@ | |
| } | ||
|
|
||
| .SkeletonThumbnail { | ||
| @include skeleton-shimmer; | ||
| @include skeleton-content; | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,3 @@ | ||
| /// Used to create the shimmer effect of skeleton components | ||
| $skeleton-shimmer-duration: duration(slower) * 2; | ||
|
|
||
| // Used by both Thumbnail and SkeletonThumbnail | ||
| $small-thumbnail-size: rem(40px); | ||
| $medium-thumbnail-size: rem(60px); | ||
|
|
@@ -16,19 +13,6 @@ $thumbnail-sizes: ( | |
| @return map-get($thumbnail-sizes, $size); | ||
| } | ||
|
|
||
| @mixin skeleton-shimmer { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This would be considered a breaking change right? I know I've seen this used in web.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Of course it is... |
||
| // This is a global animation, defined in /src/components/AppProvider/AppProvider.scss | ||
| // See that file for why this is referenced as a custom property instead of | ||
| // by name | ||
| animation: var(--polaris-animation-skeleton-shimmer) | ||
| $skeleton-shimmer-duration linear infinite alternate; | ||
| will-change: opacity; | ||
|
|
||
| @media (prefers-reduced-motion) { | ||
| animation: none; | ||
| } | ||
| } | ||
|
|
||
| @mixin skeleton-content { | ||
| position: relative; | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a keyframe reference at the end of this file that can be removed as well
https://github.com/Shopify/polaris-react/blob/main/src/components/AppProvider/AppProvider.scss#L84-L92