Migrate to sewing-kit-next to loom #4471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sewing-kit-next has been renamed to loom, and has been moved into the shopify npm namespace. Code behaviour is identical aside from the package names, the config file name and the metadata directory.
Contributor
size-limit report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
sewing-kit-nexthas been renamed toloom, and has been moved into theshopifynpm namespace. Code behaviour in the latest packages from the@sewing-kitnamespace is identical to the corresponding package in the@shopifynamespace aside from the binary name, the config file name and the metadata directory.WHAT is this pull request doing?
@sewing-kit/corewith@shopify/loom,@sewing-kit/cliwith@shopify/loom-cliand@sewing-kit/plugin-*with@shopify/loom-plugin-*loomexecutable instead ofsknsewing-kit.config.tstoloom.config.ts.loominstead of.sewing-kitin ignore filesHow to 🎩
mv build build-ogyarnto update dependencies, run ayarn cleanto delete the build folderyarn buildto generate a new builddiff -ru -x '*.tsbuildinfo' build-og buildto see that the contents of the old and new build folders are identical.