[TextField] Add maxHeight prop #4476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. |
Contributor
size-limit report
|
chloerice
approved these changes
Sep 17, 2021
Member
chloerice
left a comment
chloerice
left a comment
There was a problem hiding this comment.
Thanks for contributing @dantecatalfamo!! 🚀
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Contributor
Author
|
Thanks for the fixup! |
|
🎉 Thanks for your contribution to Polaris React! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The TextField allows multiline values, but if a long input is created, the component can become extremely tall.
maxHeightgives developers an option to cap the height of the element.I'm creating a page that needs to have a transcript pasted into a textfield, it's possibly very long and required a lot of scrolling to get to the bottom of the form. If I could limit the size of the TextForm component that wouldn't be a problem.
WHAT is this pull request doing?
Adds a
maxHeightprop to the TextField component, which adds amax-heightproperty to the component's inline style. It only appears ifmultilineis present, as it's not required otherwise.