[Stack] Revert not empty item css #4572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
force-pushed
the
stack_revert-not-empty
branch
from
ae166ee to
2b27167
Compare
Contributor
size-limit report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #4560
Reverts the change added here: https://github.com/Shopify/polaris-react/pull/4556/files#diff-12888031b1f0e16bf9d7ee02978c37cbdfd6b64f8912ad164ab1cc51410fd538R10
We've decided to ditch this effort for now and rely on consumers to render
Stack.Itemsonly if their content is not null in the same way we do withCardsandLayout.Sections