Skip to content

Conversation

@dfmcphee
Copy link
Contributor

WHY are these changes introduced?

In #4580 we changed the timeout on the unmounting of popovers to match the new instant transition. This created issues for some implementations and introduced race conditions.

WHAT is this pull request doing?

This reverts the exit timeout to the default duration base like it had before.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2021

size-limit report

Path Size
cjs 166.08 KB (+0.01% 🔺)
esm 96.63 KB (+0.01% 🔺)
esnext 143.5 KB (+0.01% 🔺)
css 34.53 KB (0%)

@dfmcphee dfmcphee merged commit 2667666 into main Nov 12, 2021
@dfmcphee dfmcphee deleted the popover-revert-exit-duration branch November 12, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants