Remove custom and unnecessary font weight properties

[lgriffee]

WHY are these changes introduced?

Part of solution for #4598

Cleaning up --p-button-font-weight and --p-badge-font-weight will allow our team to easily find and replace font-weight: 400 in the future when we define new tokens.

Removing up any unneeded global font-weight properties (ex. font-weight: inherit) will help keep our code clean and succinct.

WHAT is this pull request doing?

Replacing or removing the following font-weight values:

• --p-button-font-weight
• --p-badge-font-weight
• inherit

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:

import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated the component's README.md with documentation changes
• Tophatted documentation changes in the style guide
• For visual design changes, ping @ sarahill to update the Polaris UI kit

[github-actions]

size-limit report

Path	Size
cjs	165.96 KB (-0.02% 🔽)
esm	96.52 KB (-0.03% 🔽)
esnext	143.14 KB (+0.02% 🔺)
css	34.33 KB (+0.1% 🔺)

[lgriffee]

I believe this property can be safely removed since font-weight is being set to 400 via @include text-style-input on line 91

[alex-page]

Looks great. We just need to remove the values from:

polaris-react/src/utilities/theme/tokens.ts

Line 22 in acd9910

buttonFontWeight: '500',

[kyledurand]

Just the conflicts to clean up then !