Remove filter functions #4650
Merged
Remove filter functions #4650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-page
reviewed
Nov 16, 2021
| &:hover, | ||
| &:focus, | ||
| &:active { | ||
| @include recolor-icon( |
Member
There was a problem hiding this comment.
Is this function used a bunch? I would assume it's a filter related function. If it is we could move it to this file.
alex-page
reviewed
Nov 16, 2021
alex-page
approved these changes
Nov 16, 2021
Contributor
size-limit report
|
BPScott
reviewed
Nov 17, 2021
| @include recolor-icon( | ||
| $fill-color: var(--p-icon-on-interactive), | ||
| $filter-color: filter('white') | ||
| $filter-color: var(--p-icon-on-interactive) |
Member
There was a problem hiding this comment.
These filter-color values passed to the 3rd argument of recolor-icon are sent as the filter property. They're not actual color values, they're filters like brightness(0) saturate(100%) invert(100%).
I think changing these to colors is going to break the behaviour, which is to allow for the recoloring of icons that are passed as svg datauris and rendered with an img tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Related to #4528
Fixes
filter()part of #4592WHAT is this pull request doing?
Removing all instances of
filter()Sass function because the color system used by this function has been deprecated. Swapping out any references tofilter()with the color system custom css propertiesHow to 🎩
Most changes are in the
Navigationcomponent. Run Storybook and/or visit the Chromatic link to this branch to ensure there are no visual regressions.