Skip to content

Remove filter sass function #4676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 22, 2021
Merged

Remove filter sass function #4676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
957de06
Remove sass filter function file
lgriffee Nov 18, 2021
690f03a
Remove sass filter function imports
lgriffee Nov 18, 2021
582645d
Remove last instance of filter function
lgriffee Nov 18, 2021
b066a05
Update UNRELEASED.md
lgriffee Nov 18, 2021
d87006f
Fix UNRELEASED formatting
lgriffee Nov 18, 2021
2c4648c
Merge branch 'v8.0.0-major' into 4657-remove-filter-sass-function
alex-page Nov 22, 2021
dfb86cb
Merge branch 'v8.0.0-major' into 4657-remove-filter-sass-function
lgriffee Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t

### Breaking changes

- Removed filter sass function and color-icon() mixin ([#4676](https://github.com/Shopify/polaris-react/pull/4676))
- Renamed `--p-duration-1-0-0` and `--p-duration-1-5-0` to `--p-duration-100` and `--p-duration-150`.

### Enhancements
Expand Down
1 change: 0 additions & 1 deletion src/styles/_common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

@import './foundation/utilities';
@import './foundation/colors';
@import './foundation/filters';
@import './foundation/spacing';
@import './foundation/border-width';
@import './foundation/borders';
Expand Down
1 change: 0 additions & 1 deletion src/styles/_public-api.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

@import './foundation/utilities';
@import './foundation/colors';
@import './foundation/filters';
@import './foundation/spacing';
@import './foundation/border-width';
@import './foundation/borders';
Expand Down
34 changes: 0 additions & 34 deletions src/styles/foundation/_filters.scss
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions src/styles/shared/_icons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,3 @@
filter: $filter-color;
}
}

@mixin color-icon($value, $hue: base) {
svg {
fill: color($value, $hue);
}

img {
filter: filter($value, $hue);
}
}
Comment on lines -20 to -28
Copy link
Contributor Author

@lgriffee lgriffee Nov 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

color-icon() isn't used anywhere else in polaris-react so I think we can remove this (since we'll also be removing color() as part of v8.0.0? Also a breaking change for web.