Skip to content

Conversation

@lgriffee
Copy link
Contributor

WHY are these changes introduced?

Reverts the removal of tokens from #4620 because they are a breaking change for web and our consumers. Changes should be released on a major Polaris version—v8.0.0 not v7.4.0.

WHAT is this pull request doing?

Adds back the following tokens:

  • overrideNone: 'none'
  • overrideTransparent: 'transparent'
  • overrideOne: '1'
  • overrideVisible: 'visible'
  • overrideZero: '0'
  • nonNullContent: "''"
  • badgeMixBlendMode: 'luminosity'
  • rangeSliderThumbScale: '1.5'

@lgriffee lgriffee requested a review from kyledurand November 19, 2021 14:03
@lgriffee lgriffee self-assigned this Nov 19, 2021
@github-actions
Copy link
Contributor

size-limit report

Path Size
cjs 166.12 KB (+0.06% 🔺)
esm 96.68 KB (+0.1% 🔺)
esnext 143.23 KB (+0.06% 🔺)
css 34.28 KB (0%)

Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@lgriffee lgriffee added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Nov 19, 2021
@lgriffee lgriffee merged commit 93d9077 into main Nov 19, 2021
@lgriffee lgriffee deleted the revert_4589-remove-misc-css-custom-properties branch November 19, 2021 14:15
lgriffee added a commit that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖Skip Changelog Causes CI to ignore changelog update check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants