Fix Popover bug with fixed positioned children #4685
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Because transformed elements create a containing block for all its positioned descendants, a recent change to the Popover breaks
react-draggable-hoc.WHAT is this pull request doing?
removes the transform on the popover-overlay when it's opened
Current:
https://user-images.githubusercontent.com/1229901/142909448-a6880dc9-2d4c-48f7-ac3f-89602dd28cf1.mov
Fixed:
https://user-images.githubusercontent.com/1229901/142909436-fd697dd9-fe91-4453-9011-3a1b781962ef.mov
How to 🎩
In storybook ensure this didn't break the animation on the popover.
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes