Skip to content

Conversation

@dleroux
Copy link
Contributor

@dleroux dleroux commented Nov 22, 2021

WHY are these changes introduced?

Because transformed elements create a containing block for all its positioned descendants, a recent change to the Popover breaks react-draggable-hoc.

WHAT is this pull request doing?

removes the transform on the popover-overlay when it's opened

Current:
https://user-images.githubusercontent.com/1229901/142909448-a6880dc9-2d4c-48f7-ac3f-89602dd28cf1.mov

Fixed:
https://user-images.githubusercontent.com/1229901/142909436-fd697dd9-fe91-4453-9011-3a1b781962ef.mov

How to 🎩

In storybook ensure this didn't break the animation on the popover.

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2021

size-limit report

Path Size
cjs 166.12 KB (0%)
esm 96.68 KB (0%)
esnext 143.24 KB (+0.01% 🔺)
css 34.29 KB (+0.01% 🔺)

@dleroux dleroux marked this pull request as ready for review November 22, 2021 17:48
Copy link

@danny-williams danny-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video you link @dleroux LGTM! 👍

@dleroux dleroux merged commit 46bd38f into main Nov 23, 2021
@dleroux dleroux deleted the popover-transform branch November 23, 2021 12:27
@danny-williams
Copy link

@dleroux still seeing this issue in prod. Assuming we're held up by code freeze, ya?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants