Skip to content

Conversation

@kyledurand
Copy link
Member

WHY are these changes introduced?

Part of #4605

WHAT is this pull request doing?

Removes the JS version of our rem function. Only used internally in our tokens.ts file. Seemed like this was a decent place to start and can be safely merged into main.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@kyledurand kyledurand self-assigned this Nov 23, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021

size-limit report

Path Size
cjs 166.15 KB (-0.02% 🔽)
esm 96.73 KB (-0.03% 🔽)
esnext 143.26 KB (-0.03% 🔽)
css 34.29 KB (0%)

@kyledurand kyledurand merged commit 2053f18 into main Nov 23, 2021
@kyledurand kyledurand deleted the remove-js-rem-function branch November 23, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants