Skip to content

[Collapsible] Remove unnecessary import from Tokens #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2021
Merged

[Collapsible] Remove unnecessary import from Tokens #4722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e443ff
Remove unnecessary import from Tokens
alex-page Nov 24, 2021
0256d9e
Update UNRELEASED.md
alex-page Nov 24, 2021
19bd3f3
Update UNRELEASED.md
alex-page Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t
- Remove all color() invocations ([#4636](https://github.com/Shopify/polaris-react/pull/4636))
- Cleaned up Button styling and $button-filled mixin([#4635](https://github.com/Shopify/polaris-react/pull/4635))
- Removed `rem()` function from `tokens.ts` ([#4695](https://github.com/Shopify/polaris-react/pull/4695))
- Remove unnecessary import of `Tokens` in `Collapsible` test ([#4722](https://github.com/Shopify/polaris-react/pull/4722))

### Deprecations

Expand Down
5 changes: 2 additions & 3 deletions src/components/Collapsible/tests/Collapsible.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React, {useState, useCallback} from 'react';
import {mountWithApp} from 'tests/utilities';

import {Tokens} from '../../../utilities/theme';
import {Collapsible, CollapsibleProps} from '../Collapsible';

describe('<Collapsible />', () => {
Expand Down Expand Up @@ -69,7 +68,7 @@ describe('<Collapsible />', () => {

describe('Transition', () => {
it('passes a duration property', () => {
const duration = Tokens.duration150;
const duration = '150ms';
const collapsible = mountWithApp(
<Collapsible id="test-collapsible" open transition={{duration}} />,
);
Expand All @@ -78,7 +77,7 @@ describe('<Collapsible />', () => {
});

it('passes a timingFunction property', () => {
const timingFunction = Tokens.ease;
const timingFunction = 'cubic-bezier(0.25, 0.1, 0.25, 1)';
const collapsible = mountWithApp(
<Collapsible
id="test-collapsible"
Expand Down