Skip to content

Remove legacy tokens from .storybook/manager.js #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Remove legacy tokens from .storybook/manager.js #4729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da53fec
Remove legacy tokens
alex-page Nov 24, 2021
0789926
Update manager.js
alex-page Nov 24, 2021
a480760
Update UNRELEASED.md
alex-page Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .storybook/manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {addons} from '@storybook/addons';
import {create} from '@storybook/theming';
import {colorSkyLight, colorInk} from '@shopify/polaris-tokens';

addons.setConfig({
panelPosition: 'bottom',
Expand All @@ -10,10 +9,5 @@ addons.setConfig({
brandUrl: '/',
brandImage: null,
appBorderRadius: 0,
appBg: colorSkyLight,
contentBg: colorSkyLight,
textColor: colorInk,
// TODO more pretty brand colors?
// SEE https://github.com/storybooks/storybook/blob/next/docs/src/pages/configurations/theming/index.md
}),
});
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t
- Cleaned up Button styling and $button-filled mixin([#4635](https://github.com/Shopify/polaris-react/pull/4635))
- Removed `rem()` function from `tokens.ts` ([#4695](https://github.com/Shopify/polaris-react/pull/4695))
- Remove unnecessary import of `Tokens` in `Collapsible` test ([#4722](https://github.com/Shopify/polaris-react/pull/4722))
- Remove legacy tokens and use default theme for `.storybook/manager.js` ([#4729](https://github.com/Shopify/polaris-react/pull/4729))

### Deprecations

Expand Down