[Page] Deprecate thumbnail property #4733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
kyledurand
reviewed
Nov 25, 2021
Member
kyledurand
left a comment
kyledurand
left a comment
There was a problem hiding this comment.
We could also add something like this in the file
if (process.env.NODE_ENV === 'development' && thumbnail != null) {
console.warn('The thumbnail prop from Page has been deprecated');
}
4 tasks
kyledurand
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This functionality is rarely used in our product and should be replaced with layout primitives in the future.
WHAT is this pull request doing?
Deprecating the thumbnail property