Skip to content

Conversation

@alex-page
Copy link
Member

WHY are these changes introduced?

Page component no longer has secondary actions placed where this component renders them. It also adds an unnecessary layer of complexity with random sizes.

WHAT is this pull request doing?

Deprecates secondaryActions and removes the examples.

@alex-page alex-page self-assigned this Nov 26, 2021
Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much 🔥 this week

@alex-page alex-page merged commit c784d2a into main Nov 26, 2021
@alex-page alex-page deleted the skeletonpage-deprecate-secondaryActions branch November 26, 2021 19:08
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2021

size-limit report

Path Size
cjs 165.74 KB (0%)
esm 96.39 KB (0%)
esnext 143.07 KB (0%)
css 34.34 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants