Skip to content

Conversation

amrocha
Copy link
Contributor

@amrocha amrocha commented Oct 26, 2018

WHY are these changes introduced?

https://github.com/Shopify/polaris-styleguide/pull/2314

WHAT is this pull request doing?

Fixing links

How to 🎩

Build for the styleguide, then run the broken link checker

Copy-paste this code in playground/Playground.tsx:
/* eslint-disable */

import * as React from 'react';
import {Page, AppProvider} from '@shopify/polaris';

interface State {}

export default class Playground extends React.Component<never, State> {
  render() {
    return (
      <AppProvider>
        <Page title="Playground">
          {/* Add the code you want to test here */}
        </Page>
      </AppProvider>
    );
  }
}

🎩 checklist

@ghost
Copy link

ghost commented Oct 26, 2018

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

@BPScott BPScott temporarily deployed to polaris-react-pr-478 October 26, 2018 14:15 Inactive
Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, re-ran CI and it looks like it failed again for issues unrelated to the pr

@amrocha
Copy link
Contributor Author

amrocha commented Oct 26, 2018

I know what that is, the config for CircleCI got messed up when we did the switch, I'll see if I can fix it

@tmlayton
Copy link
Contributor

This just needed a rebase, also updated the changelog entry with the new PR link.

@danrosenthal
Copy link

What's the status on this PR @amrocha?

@amrocha
Copy link
Contributor Author

amrocha commented Nov 13, 2018

Needs to be merged together with https://github.com/Shopify/polaris-styleguide/pull/2314 which isn't ready yet

@amrocha amrocha merged commit 0dc1a94 into master Nov 27, 2018
@ghost
Copy link

ghost commented Nov 27, 2018

🎉 Thanks for your contribution to Polaris React!

@amrocha amrocha deleted the updated-IA-links branch November 27, 2018 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants