Bump node-sass and sass-loader #4783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report
|
Member
|
Looks like the use of matrix has changed the CI run name slightly - you'll need to go update the branch protection rules to remove the "Test" expectation and add "Test (12.22.0)" after merging. You might also need to update shipit.yml - https://github.com/Shopify/polaris-react/blob/main/shipit.yml#L3 |
BPScott
approved these changes
Dec 2, 2021
kyledurand
added a commit
that referenced
this pull request
Dec 2, 2021
* Bump node-sass and sass-loader * unreleased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Needed to fix test runs in v8 where size limit build node 12 and node 16 bundles