Update eslint

[BPScott]

WHY are these changes introduced?

Keeping up to date.

WHAT is this pull request doing?

• Update eslint to v8.3.0 and @shopify/eslint-plugin to v41.0.1
• Update babel/* rules to be @babel/*
• Apply autofixes
• Adjust generic naming so generic names start with a T
• Replace usage of toBeTruthy / toBeFalsey in tests with toBeDefined / toBe(true) / toBeFalse() etc
• Ensure key props are always before spreads to keep react/jsx-key happy
• Ignore occasional hardcoded-content warnings
• Add useMemo to a few places to prevent always rerendering to keep react/jsx-no-constructed-context-values happy

To Test

CI passes

[github-actions]

size-limit report

Path	Size
cjs	165.75 KB (+0.02% 🔺)
esm	96.41 KB (+0.03% 🔺)
esnext	143.1 KB (+0.02% 🔺)
css	34.34 KB (0%)

[caution-tape-bot]

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

[kyledurand]

🙌

[kyledurand]

Necessary or optimizing?

[BPScott]

Eslint warns with react/jsx-no-constructed-context-values when you sick something in a context that shall cause the context to be updated on every single rerender regardless of if the content changes or not. With the fix being to memoize objects you pass into contexts.

In this particular case it's probably not a big deal as we probably aren't causing rerenders on PolarisTestProvider because, but it's an easy fix to write code in the way to keep the linter happy rather than sprinkling eslint-disable-next-lines around