Skip to content

Conversation

@BPScott
Copy link
Member

@BPScott BPScott commented Dec 4, 2021

WHY are these changes introduced?

Keeping up to date

WHAT is this pull request doing?

  • Update stylelint to v14.1.0 and @shopify/stylelint-plugin to v11.0.0
  • run yarn lint --fix to fixup a bunch of autofixable errors (mostly whitespace adjustments)
  • Manually fixup removing unneeded disabling of rules.

How to 🎩

yarn lint --no-cache passes

@BPScott BPScott requested a review from kyledurand December 4, 2021 00:25
@caution-tape-bot
Copy link

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2021

size-limit report

Path Size
cjs 165.74 KB (0%)
esm 96.39 KB (0%)
esnext 143.07 KB (0%)
css 34.34 KB (0%)

Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🙌

@BPScott BPScott merged commit 983fc7b into main Dec 6, 2021
@BPScott BPScott deleted the update-stylelint branch December 6, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants