Skip to content

[Banner] Fix focus border on secondary action button in banners #4997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2022
Merged

[Banner] Fix focus border on secondary action button in banners #4997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8848add
Replaces focus border on secondary action button in banners
afairbrother Feb 1, 2022
93ae8c2
Add release notes to Unreleased.md
afairbrother Feb 1, 2022
98b3f5e
Update order of mixins so it matches
afairbrother Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t
- Removed `min-height` from `Page` `additionalNavigation` ([#4952](https://github.com/Shopify/polaris-react/pull/4952))
- Fixed overly dark `bottom-border` on `DataTable` header cell and total cell ([#4975](https://github.com/Shopify/polaris-react/pull/4975))
- Removed `min-height` on `Autocomplete` `action` ([#4977](https://github.com/Shopify/polaris-react/pull/4977))
- Fixed `focus-ring` on `Banner` `secondaryAction` ([#4997](https://github.com/Shopify/polaris-react/pull/4997))

### Documentation

Expand Down
3 changes: 3 additions & 0 deletions src/components/Banner/Banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,11 +257,14 @@ $spinner-size: rem(20px);
&:focus > .Text {
@include plain-button-backdrop;
@include high-contrast-button-outline;
@include focus-ring($style: 'focused');
box-shadow: none;
background-color: transparent;
}
}

.Text {
@include focus-ring;
box-shadow: 0 -2px 0 0 rgba(var(--p-rgb-text), 0.25) inset;
will-change: box-shadow;
transition: box-shadow duration() easing();
Expand Down