Skip to content

Fix hard coded px tokens #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Fix hard coded px tokens #5000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t
- Fixed a bug where the `Listbox.Action` was not treated like an action when used outside `Autocomplete` ([#4893](https://github.com/Shopify/polaris-react/pull/4893))
- Fixed a bug where the `Checkbox` in a `Combobox` with `allowMultiple` would steal focus and close the `Popover` when clicked ([#4895](https://github.com/Shopify/polaris-react/pull/4895))
- Fixed an issue where `TextField` was the wrong height on initial render ([#4903](https://github.com/Shopify/polaris-react/pull/4903))
- Fixed an issue where token values in px weren't converted to rems ([#5000](https://github.com/Shopify/polaris-react/pull/5000))

### Documentation

Expand Down
88 changes: 44 additions & 44 deletions documentation/Color system.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,47 +255,47 @@ Used to decorate elements where color does convey a specific meaning in componen

### UNSTABLE these may become @deprecated at any time

| CSS variable | Value |
| ----------------------------------------- | ------------------------------------------------------------------------------------------------------------ |
| `--p-border-radius-slim` | `0.2rem` |
| `--p-border-radius-base` | `0.4rem` |
| `--p-border-radius-wide` | `0.8rem` |
| `--p-border-radius-full` | `50%` |
| `--p-card-shadow` | `0px 0px 5px var(--p-shadow-from-ambient-light), 0px 1px 2px var(--p-shadow-from-direct-light)` |
| `--p-popover-shadow` | `-1px 0px 20px var(--p-shadow-from-ambient-light), 0px 1px 5px var(--p-shadow-from-direct-light)` |
| `--p-modal-shadow` | `0px 26px 80px var(--p-shadow-from-dim-light), 0px 0px 1px var(--p-shadow-from-dim-light)` |
| `--p-top-bar-shadow` | `0 2px 2px -1px var(--p-shadow-from-direct-light)` |
| `--p-button-drop-shadow` | `0 1px 0 rgba(0, 0, 0, 0.05)` |
| `--p-button-inner-shadow` | `inset 0 -1px 0 rgba(0, 0, 0, 0.2)` |
| `--p-button-pressed-inner-shadow` | `inset 0 1px 0 rgba(0, 0, 0, 0.15)` |
| `--p-override-none` | `none` |
| `--p-override-transparent` | `transparent` |
| `--p-override-one` | `1` |
| `--p-override-visible` | `visible` |
| `--p-override-zero` | `0` |
| `--p-override-loading-z-index` | `514` |
| `--p-button-font-weight` | `500` |
| `--p-non-null-content` | `''` |
| `--p-choice-size` | `2rem` |
| `--p-icon-size` | `1rem` |
| `--p-choice-margin` | `0.1rem` |
| `--p-control-border-width` | `0.2rem` |
| `--p-banner-border-default` | `inset 0 0.1rem 0 0 var(--p-border-neutral-subdued), inset 0 0 0 0.1rem var(--p-border-neutral-subdued)` |
| `--p-banner-border-success` | `inset 0 0.1rem 0 0 var(--p-border-success-subdued), inset 0 0 0 0.1rem var(--p-border-success-subdued)` |
| `--p-banner-border-highlight` | `inset 0 0.1rem 0 0 var(--p-border-highlight-subdued), inset 0 0 0 0.1rem var(--p-border-highlight-subdued)` |
| `--p-banner-border-warning` | `inset 0 0.1rem 0 0 var(--p-border-warning-subdued), inset 0 0 0 0.1rem var(--p-border-warning-subdued)` |
| `--p-banner-border-critical` | `inset 0 0.1rem 0 0 var(--p-border-critical-subdued), inset 0 0 0 0.1rem var(--p-border-critical-subdued)` |
| `--p-badge-mix-blend-mode` | `luminosity` |
| `--p-thin-border-subdued` | `0.1rem solid var(--p-border-subdued)` |
| `--p-text-field-spinner-offset` | `0.2rem` |
| `--p-text-field-focus-ring-offset` | `-0.4rem` |
| `--p-text-field-focus-ring-border-radius` | `0.7rem` |
| `--p-button-group-item-spacing` | `-0.1rem` |
| `--p-duration-1-0-0` | `100ms` |
| `--p-duration-1-5-0` | `150ms` |
| `--p-ease-in` | `cubic-bezier(0.5, 0.1, 1, 1)` |
| `--p-ease` | `cubic-bezier(0.4, 0.22, 0.28, 1)` |
| `--p-range-slider-thumb-size-base` | `1.6rem` |
| `--p-range-slider-thumb-size-active` | `2.4rem` |
| `--p-range-slider-thumb-scale` | `1.5` |
| `--p-badge-font-weight` | `400` |
| CSS variable | Value |
| --------------------------------------- | ------------------------------------------------------------------------------------------------------ |
| `--p-border-radius-slim` | `0.125rem` |
| `--p-border-radius-base` | `0.25rem` |
| `--p-border-radius-wide` | `0.5rem` |
| `--p-border-radius-full` | `50%` |
| `--p-card-shadow` | `0px 0px 5px var(--p-shadow-from-ambient-light), 0px 1px 2px var(--p-shadow-from-direct-light)` |
| `--p-popover-shadow` | `-1px 0px 20px var(--p-shadow-from-ambient-light), 0px 1px 5px var(--p-shadow-from-direct-light)` |
| `--p-modal-shadow` | `0px 26px 80px var(--p-shadow-from-dim-light), 0px 0px 1px var(--p-shadow-from-dim-light)` |
| `--p-top-bar-shadow` | `0 2px 2px -1px var(--p-shadow-from-direct-light)` |
| `--p-button-drop-shadow` | `0 1px 0 rgba(0, 0, 0, 0.05)` |
| `--p-button-inner-shadow` | `inset 0 -1px 0 rgba(0, 0, 0, 0.2)` |
| `--p-button-pressed-inner-shadow` | `inset 0 1px 0 rgba(0, 0, 0, 0.15)` |
| `--p-override-none` | `none` |
| `--p-override-transparent` | `transparent` |
| `--p-override-one` | `1` |
| `--p-override-visible` | `visible` |
| `--p-override-zero` | `0` |
| `--p-override-loading-z-index` | `514` |
| `--p-button-font-weight` | `500` |
| `--p-non-null-content` | `''` |
| `--p-choice-size` | `1.25rem` |
| `--p-icon-size` | `0.625rem` |
| `--p-choice-margin` | `0.0625rem` |
| `--p-control-border-width` | `0.125rem` |
| `--p-banner-border-default` | `inset 0 1px 0 0 var(--p-border-neutral-subdued), inset 0 0 0 1px var(--p-border-neutral-subdued)` |
| `--p-banner-border-success` | `inset 0 1px 0 0 var(--p-border-success-subdued), inset 0 0 0 1px var(--p-border-success-subdued)` |
| `--p-banner-border-highlight` | `inset 0 1px 0 0 var(--p-border-highlight-subdued), inset 0 0 0 1px var(--p-border-highlight-subdued)` |
| `--p-banner-border-warning` | `inset 0 1px 0 0 var(--p-border-warning-subdued), inset 0 0 0 1px var(--p-border-warning-subdued)` |
| `--p-banner-border-critical` | `inset 0 1px 0 0 var(--p-border-critical-subdued), inset 0 0 0 1px var(--p-border-critical-subdued)` |
| `--p-badge-mix-blend-mode` | `luminosity` |
| `--p-thin-border-subdued` | `1px solid var(--p-border-subdued)` |
| `--p-text-field-spinner-offset` | `0.125rem` |
| `--p-text-field-focus-ring-offset` | `-0.25rem` |
| `--p-text-field-focus-ring-border-radi` | `0.4375rem` |
| `--p-button-group-item-spacing` | `-0.0625rem` |
| `--p-duration-1-0-0` | `100ms` |
| `--p-duration-1-5-0` | `150ms` |
| `--p-ease-in` | `cubic-bezier(0.5, 0.1, 1, 1)` |
| `--p-ease` | `cubic-bezier(0.4, 0.22, 0.28, 1)` |
| `--p-range-slider-thumb-size-base` | `1rem` |
| `--p-range-slider-thumb-size-active` | `1.5rem` |
| `--p-range-slider-thumb-scale` | `1.5` |
| `--p-badge-font-weight` | `400` |
Loading