Skip to content

[Banner] Fixes unexpected text wrap in Firefox on focus of secondary action button #5001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 3, 2022
Merged

[Banner] Fixes unexpected text wrap in Firefox on focus of secondary action button #5001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02464bc
Fixes unexpected textwrap on Firefox in secondaryAction in Banner
afairbrother Feb 2, 2022
bdc0635
Updates unreleased.md
afairbrother Feb 2, 2022
77439cd
Added clearer unreleased notes
afairbrother Feb 2, 2022
37acad3
Update to use line height to satisfy chromatic diff
afairbrother Feb 2, 2022
ba8ea31
Update Unreleased and add clarity
afairbrother Feb 2, 2022
0bcec34
Fix duplicate in Unreleased
afairbrother Feb 2, 2022
f1f5c90
Fix the underline on chrome without using line height
afairbrother Feb 2, 2022
24b79e4
Fix unreleased notes
afairbrother Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UNRELEASED.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Use [the changelog guidelines](/documentation/Versioning%20and%20changelog.md) t
- Fixed a bug where the `Checkbox` in a `Combobox` with `allowMultiple` would steal focus and close the `Popover` when clicked ([#4895](https://github.com/Shopify/polaris-react/pull/4895))
- Fixed an issue where `TextField` was the wrong height on initial render ([#4903](https://github.com/Shopify/polaris-react/pull/4903))
- Fixed an issue where token values in px weren't converted to rems ([#5000](https://github.com/Shopify/polaris-react/pull/5000))
- Fixed `display` on `Banner` `secondaryAction` on focus in Firefox ([#5001](https://github.com/Shopify/polaris-react/pull/5001))

### Documentation

Expand Down
1 change: 1 addition & 0 deletions src/components/Banner/Banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ $spinner-size: rem(20px);
@include focus-ring($style: 'focused');
box-shadow: none;
background-color: transparent;
display: block;
}
}

Expand Down