Skip to content

Include migration guidance on css custom properties #5011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 4, 2022
Merged

Include migration guidance on css custom properties #5011

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8d5e18c
Include migration guidance on css custom properties
aveline Feb 2, 2022
cee27d5
🙊
aveline Feb 2, 2022
aed0d21
Update migrating-from-v8-to-v9.md
aveline Feb 2, 2022
99cecc2
Update migrating-from-v8-to-v9.md
aveline Feb 2, 2022
3d96dbc
Update migrating-from-v8-to-v9.md
aveline Feb 2, 2022
6d8b556
Update migrating-from-v8-to-v9.md
aveline Feb 2, 2022
72b1a47
Update documentation/guides/migrating-from-v8-to-v9.md
aveline Feb 3, 2022
8ef3922
Update migrating-from-v8-to-v9.md
aveline Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions documentation/guides/migrating-from-v8-to-v9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,42 @@ Polaris v9.0.0 ([full release notes](https://github.com/Shopify/polaris-react/re

## Theme provider

## CSS Custom Properties

CSS custom properties that were renamed can be replaced with the new CSS custom property name.

| Before | After |
| :-------------------------------: | :--------------------------------: |
| `--p-badge-font-weight` | `--p-font-weight-regular` |
| `--p-button-font-weight` | `--p-font-weight-medium` |
| `--p-duration-1-0-0` | `--p-duration-100` |
| `--p-duration-1-5-0` | `--p-duration-150` |
| `--p-card-shadow` | `--p-shadow-card` |
| `--p-popover-shadow` | `--p-shadow-popover` |
| `--p-modal-shadow` | `--p-shadow-modal` |
| `--p-top-bar-shadow` | `--p-shadow-top-bar` |
| `--p-button-drop-shadow` | `--p-shadow-button` |
| `--p-button-inner-shadow` | `--p-shadows-inset-button` |
| `--p-button-pressed-inner-shadow` | `--p-shadows-inset-button-pressed` |
| `--p-icon-size` | `--p-icon-size-small` |

CSS custom properties that have been deprecated can be replaced with the CSS property value.

| Before | Value |
| :-----------------------------: | :----------------------: |
| `--p-override-none` | `none` |
| `--p-override-transparent` | `transparent` |
| `--p-override-one` | `1` |
| `--p-override-visible` | `visible` |
| `--p-override-zero` | `0` |
| `--p-non-null-content` | `''` |
| `--p-badge-mix-blend-mode` | `luminosity` |
| `--p-range-slider-thumb-scale` | `1.5` |
| `--p-frame-offset` | `0px` |
| `--p-shadow-from-ambient-light` | `rgba(23, 24, 24, 0.05)` |
| `--p-shadow-from-direct-light` | `rgba(0, 0, 0, 0.15)` |
| `--p-shadow-from-dim-light` | `rgba(0, 0, 0, 0.2)` |

## Removal of the public scss api

Any functions that were being consumed from `build/styles/_public-api.scss` have been removed. The functions can be found in the following permalinks.
Expand Down