Skip to content

Create migration guidance for shadow() function #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Create migration guidance for shadow() function #5051

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03ab97a
Create migration guidance for shadow() and tokens
lgriffee Feb 4, 2022
4977a34
Merge branch 'v9.0.0-major' of https://github.com/Shopify/polaris-rea…
lgriffee Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 34 additions & 9 deletions documentation/guides/migrating-from-v8-to-v9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,17 @@ To help you quickly add these functions and mixins back to your repo, we've crea

A list of functions/mixins and their value equivalents or new token values.

#### `duration()`
Copy link
Contributor Author

@lgriffee lgriffee Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this up here so all the functions/mixins are in alphabetical order.


| Function | Replacement Value/Token |
| -------------------------------- | ----------------------- |
| `duration(none)` | 0 |
| `duration(fast)` | `--p-duration-100` |
| `duration()`<br>`duration(base)` | `--p-duration-200` |
| `duration(slow)` | `--p-duration-300` |
| `duration(slower)` | `--p-duration-400` |
| `duration(slowest)` | `--p-duration-500` |

#### `easing()`

| Function | Replacement Value/Token |
Expand All @@ -100,16 +111,15 @@ A list of functions/mixins and their value equivalents or new token values.
| `easing(overshoot)` | `cubic-bezier(0.07, 0.28, 0.32, 1.22)` |
| `easing(anticipate)` | `cubic-bezier(0.38, -0.4, 0.88, 0.65)` |

#### `duration()`
#### `shadow()`

| Function | Replacement Value/Token |
| -------------------------------- | ----------------------- |
| `duration(none)` | 0 |
| `duration(fast)` | `--p-duration-100` |
| `duration()`<br>`duration(base)` | `--p-duration-200` |
| `duration(slow)` | `--p-duration-300` |
| `duration(slower)` | `--p-duration-400` |
| `duration(slowest)` | `--p-duration-500` |
| Function | Replacement Value/Token |
| ---------------------------- | ------------------------ |
| `shadow(faint)` | `--p-shadow-faint` |
| `shadow()`<br>`shadow(base)` | `--p-shadow-base` |
| `shadow(deep)` | `--p-shadow-deep` |
| `shadow(layer)` | `--p-shadow-layer` |
| `shadow(transparent)` | `--p-shadow-transparent` |

## Tokens

Expand All @@ -120,6 +130,21 @@ A list of functions/mixins and their value equivalents or new token values.
| `--p-duration-1-0-0` | `--p-duration-100` |
| `--p-duration-1-5-0` | `--p-duration-150` |

### Shadow

| Token | Replacement Value/Token |
| --------------------------------- | ---------------------------------- |
| `--p-card-shadow` | `--p-shadow-card` |
| `--p-popover-shadow` | `--p-shadow-popover` |
| `--p-modal-shadow` | `--p-shadow-modal` |
| `--p-top-bar-shadow` | `--p-shadow-top-bar` |
| `--p-button-drop-shadow` | `--p-shadow-button` |
| `--p-button-inner-shadow` | `--p-shadows-inset-button` |
| `--p-button-pressed-inner-shadow` | `--p-shadows-inset-button-pressed` |
| `--p-shadow-from-ambient-light` | `rgba(23, 24, 24, 0.05)` |
| `--p-shadow-from-direct-light` | `rgba(0, 0, 0, 0.15)` |
| `--p-shadow-from-dim-light` | `rgba(0, 0, 0, 0.2)` |

## Removal of the public scss api

Any functions that were being consumed from `build/styles/_public-api.scss` have been removed. The functions can be found in the following permalinks.
Expand Down