Skip to content

Create migration guidance for high-contrast-outline() and high-contrast-border() mixins #5112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Create migration guidance for high-contrast-outline() and high-contrast-border() mixins #5112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bc3a23
Add documentation for high-contrast-outline() and high-contrast-border()
lgriffee Feb 9, 2022
c34c7e6
Merge branch 'v9.0.0-major' into 5043-migration-guide-high-contrast-m…
lgriffee Feb 9, 2022
ef6d310
Fix typo
lgriffee Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions documentation/guides/migrating-from-v8-to-v9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ A list of functions/mixins and their value equivalents or new token values.
| `border-radius()`<br>`border-radius(base)` | `--p-border-radius-base` |
| `border-radius(large)` | `--p-border-radius-large` |

#### `border-width()`
Copy link
Contributor Author

@lgriffee lgriffee Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this because I'm linking to the header below.


#### `duration()`

| Function | Replacement Value/Token |
Expand Down Expand Up @@ -217,6 +219,28 @@ We replaced a few of the following filter function instances with color tokens i
| `font-family()`<br>`font-family($family: base)` | `--p-font-family-sans` |
| `font-family($family: 'monospace')` | `--p-font-family-mono` |

#### `high-contrast-border()`

| Mixin | Replacement Value/Token |
| -------------------------------------------------------------- | ---------------------------------------------------- |
| `@include high-contrast-border` | `border: var(--p-border-width-1) solid transparent;` |
| `@include high-contrast-border($border-width: <border-width>)` | `border: <border-width> solid transparent;` |

For `<border-width>` instances that are functions, see the [`border-width()`](#border-width) section for replacing it.

For `<border-width>` instances that are hard coded values, see if you can replace it with one of our [new border-width tokens](https://github.com/Shopify/polaris-react/blob/77e8669595a4964ff5ce399967661a7621ea2a4d/src/tokens/token-groups/shape.json), otherwise leave it hardcoded.

#### `high-contrast-outline()`

| Mixin | Replacement Value/Token |
| --------------------------------------------------------------- | ----------------------------------------------------- |
| `@include high-contrast-outline` | `outline: var(--p-border-width-1) solid transparent;` |
| `@include high-contrast-outline($border-width: <border-width>)` | `outline: <border-width> solid transparent;` |

For `<border-width>` instances that are functions, see the [`border-width()`](#border-width) section for replacing it.

For `<border-width>` instances that are hard coded values, see if you can replace it with one of our [new border-width tokens](https://github.com/Shopify/polaris-react/blob/77e8669595a4964ff5ce399967661a7621ea2a4d/src/tokens/token-groups/shape.json), otherwise leave it hardcoded.

#### `ms-high-contrast-color()`

| Function | Replacement Value/Token |
Expand Down