Skip to content

Conversation

@mrcthms
Copy link
Contributor

@mrcthms mrcthms commented Feb 10, 2022

WHY are these changes introduced?

The recent Nav density work updated spacing in the Navigation, but after the recent base font size update, things are looking a little wonky. This PR fixes the wonkiness in the Navigation and aligns it as it should be.

WHAT is this pull request doing?

Updates include:

  • Correct margin between edge of NavigationItem and icon
  • Correct margin between icon and text within NavigationItem
  • Correct padding-left of a SecondaryNavigation to align with text within an NavigationItem
  • Correct padding-left of a SectionHeading to align with the icon

Screenshot 2022-02-10 at 18 17 20

Screenshot 2022-02-10 at 18 17 06

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2022

size-limit report

Path Size
cjs 164.56 KB (0%)
esm 94.3 KB (0%)
esnext 141.38 KB (-0.02% 🔽)
css 34.64 KB (-0.05% 🔽)

@mrcthms mrcthms added 🤖Skip Changelog Causes CI to ignore changelog update check. and removed 🤖Skip Changelog Causes CI to ignore changelog update check. labels Feb 10, 2022
@alex-page alex-page merged commit bb1eaf3 into main Feb 10, 2022
@alex-page alex-page deleted the nav-alignment branch February 10, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants