Skip to content

Migration guide for skeleton mixins #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2022
Merged

Migration guide for skeleton mixins #5141

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38e3159
Add documentation for skeleton-page-header-layout() mixin
lgriffee Feb 10, 2022
ee9fb67
Add documentation for skeleton-page-secondary-actions-layout() mixin
lgriffee Feb 10, 2022
e9fb6ea
Create documentation for skeleton-shimmer() mixin
lgriffee Feb 10, 2022
7c0f242
Remove extra semicolon
lgriffee Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 73 additions & 0 deletions documentation/guides/migrating-from-v8-to-v9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,79 @@ This function has been deprecated, but the definition can be copied and used loc
| `shadow(layer)` | `--p-shadow-layer` |
| `shadow(transparent)` | `--p-shadow-transparent` |

#### `skeleton-page-header-layout()`

| Deprecated Mixin | Replacement Value |
| -------------------------------------- | ---------------------------------- |
| `@include skeleton-page-header-layout` | `padding-bottom: var(--p-space-2)` |

#### `skeleton-page-secondary-actions-layout()`

<table>
Copy link
Contributor Author

@lgriffee lgriffee Feb 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using HTML markdown for some of these sections since I have code blocks inside the tables

<tr>
<th>Deprecated Mixin</th>
<th>Replacement Value</th>
</tr>
<tr>
<td>

`@include skeleton-page-secondary-actions-layout`

</td>
<td>

```scss
margin-top: var(--p-space-2);
display: flex;
flex-direction: row-reverse;
justify-content: flex-end;
align-items: center;
```

</td>
</tr>
</table>

#### `skeleton-shimmer()`

We completely removed motion from our skeleton components for a better user experience but if you want to keep the functionality of this mixin you can reference the table below for replacement values.

<table>
<tr>
<th>Deprecated Mixin</th>
<th>Replacement Value</th>
</tr>
<tr>
<td>

`@include skeleton-shimmer`

</td>
<td>

```scss
animation: shimmer 800ms linear infinite alternate;
will-change: opacity;

@keyframes shimmer {
0% {
opacity: 0.45;
}

100% {
opacity: 0.9;
}
}

@media (prefers-reduced-motion) {
animation: none;
}
```

</td>
</tr>
</table>

#### `spacing()`

| Function | Replacement Value/Token |
Expand Down