Skip to content

Create migration guidance for Sass global variables #5160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 11, 2022
Merged

Create migration guidance for Sass global variables #5160

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7edb31d
Add documentation for sass global variables
lgriffee Feb 11, 2022
5267a30
Merge branch 'v9.0.0-major' of https://github.com/Shopify/polaris-rea…
lgriffee Feb 11, 2022
72e9825
Consolidate table
lgriffee Feb 11, 2022
37db1da
Fix casing
lgriffee Feb 11, 2022
f2e8df5
Fix the right casing
lgriffee Feb 11, 2022
08c226d
Merge branch 'v9.0.0-major' into 5006-migration-guide-sass-global-var…
lgriffee Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions documentation/guides/migrating-from-v8-to-v9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,16 @@ Any functions that were being consumed from `build/styles/_public-api.scss` have

[Legacy Polaris V8 public scss api](https://github.com/Shopify/polaris-react/blob/b443d114d447df15d9e72914c8ca5058439a175e/documentation/guides/legacy-polaris-v8-public-api.scss)

## Sass global variables

The following Sass global variables have been removed because the functions using them have been removed. If you wish to continue using them you can add them directly to your repo.

| Deprecated Variable | Value |
| -------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `$color-palette-data`<br/>`$polaris-colors` | [definition](https://github.com/Shopify/polaris-react/blob/5267a30b845a0c07bec4036d723fb11c2cb24100/documentation/guides/legacy-polaris-v8-public-api.scss#L5-L88) |
| `$duration-data`<br/>`$polaris-duration-map` | [definition](https://github.com/Shopify/polaris-react/blob/5267a30b845a0c07bec4036d723fb11c2cb24100/documentation/guides/legacy-polaris-v8-public-api.scss#L243-L262) |
| `$easing-data` | [definition](https://github.com/Shopify/polaris-react/blob/5267a30b845a0c07bec4036d723fb11c2cb24100/documentation/guides/legacy-polaris-v8-public-api.scss#L678-L685) |

## `@shopify/polaris-tokens`

`@shopify/polaris-tokens` is no longer a dependency. The library will continue to be available via NPM, however we highly encourage removing any usage in your application.