Showing the Popover issue #5176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandcote
force-pushed
the
popover-issue
branch
from
281e975 to
a4150b0
Compare
alexandcote
commented
Feb 14, 2022
| <Page title="Playground"> | ||
| {/* Add the code you want to test in here */} | ||
| </Page> | ||
| <div |
Contributor
Author
There was a problem hiding this comment.
This component only replicates the small window.
| ); | ||
|
|
||
| return ( | ||
| // Frame without topBar doesn't have the issue. |
Contributor
There was a problem hiding this comment.
I can still replicate the issue both in Playground in a Frame without the TopBar, and in online-store-web after manually removing the data-polaris-top-bar attribute from the TopBar div.
It seems to be related to whether the activator is on screen? Going to dig further. FWIW, the Popover is being closed by the ScrollOut event.
Screen.Recording.2022-02-15.at.09.58.47.mov
Contributor
|
Merchant videos for additional context: |
Contributor
|
Closed in favour of: #5181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replicates an issue we found in version >=7.4.0 of Polaris
Screenshot
Screen.Recording.2022-02-14.at.6.04.53.PM.mov
This PR introduce the functionality
cc @dfmcphee