[Autocomplete] Fix section break placement in README #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack. |
chloerice
changed the title
chloerice
force-pushed
the
fix-autocomplete-readme
branch
from
c19a121 to
3c7aaf3
Compare
amrocha
approved these changes
Nov 9, 2018
|
🎉 Thanks for your contribution to Polaris React! |
|
Oh, I'm sorry, I thought I had included the horizontal divider. Thank you, @chloerice, that explains why it works for me now. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes #590
WHAT is this pull request doing?
Fixes misplacement of the Markdown horizontal rule so that the last example gets parsed properly.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
git checkout fix-autocomplete-readme && yarn run build-consumer polaris-styleguide🎩 checklist