[TopBar] Fix justification for UserMenu #597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
If a TopBar implements a
userMenu
but not asearchField
, theuserMenu
is left-aligned. It should always remain right-aligned.Resolves #566
WHAT is this pull request doing?
Sets
justify-content: flex-end;
on the TopBar's.Contents
container (it's already using flexbox)Before:

After:

How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
The Top Bar component can take in three components as props:
searchField
,secondaryMenu
, anduserMenu
. Be sure to test cases with different combinations of these props (i.e.: using asearchField
and nothing else or asecondaryMenu
and auserMenu
but not asearchField
).Copy-paste this code in
playground/Playground.tsx
:🎩 checklist