Skip to content

Fix frame embedded app context errors #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2018
Merged

Fix frame embedded app context errors #613

merged 2 commits into from
Nov 13, 2018

Conversation

AndrewMusgrave
Copy link
Member

@AndrewMusgrave AndrewMusgrave commented Nov 13, 2018 •
edited by tmlayton
Loading

Fixes #611

@BPScott BPScott temporarily deployed to polaris-react-pr-613 November 13, 2018 22:52 Inactive
tmlayton
tmlayton approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@tmlayton tmlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this resolves #611 – can you add a changelog entry? Otherwise 👍

@tmlayton tmlayton force-pushed the fix-eba-errors-frame branch from c86894f to db361be Compare November 13, 2018 23:32
@tmlayton tmlayton merged commit e7250cc into master Nov 13, 2018
@tmlayton tmlayton deleted the fix-eba-errors-frame branch November 13, 2018 23:44
@AndrewMusgrave
Copy link
Member Author

Thanks Tim 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tmlayton tmlayton tmlayton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AndrewMusgrave @tmlayton @BPScott