[ResourceList.Item] Add support for cmd / ctrl click

[kyledurand]

WHY are these changes introduced?

Resolves an issue outlined in a project I'm working now where users cannot command / control click to open up list items in new tabs.

This is useful for opening more than one item at a time.

WHAT is this pull request doing?

Fixes the above ☝️

🎩 checklist

• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated UNRELEASED.md

[ghost]

👋 Thanks for opening your first pull request. A contributor should give feedback soon. If you haven’t already, please check out the contributing guidelines. You can also join #polaris on the Shopify Partners Slack.

[lemonmade]

This isn't specifically relevant to this implementation, but why are we not just relying on native link behaviours here?

[danrosenthal]

This isn't specifically relevant to this implementation, but why are we not just relying on native link behaviours here?

Resource list items often contain links and buttons, so we have not implemented the item as a link as links can't contain other links.

[dfmcphee]

Resource list items often contain links and buttons, so we have not implemented the item as a link as links can't contain other links.

Didn't we used to have a version that overlayed a visually hidden a tag so that you got this behaviour without the nesting?

[danrosenthal]

Didn't we used to have a version that overlayed a visually hidden a tag so that you got this behaviour without the nesting?

We do something like this in the polaris rails implementation of resource list, but that's not without its problems (issues like highlighting and selecting text.)

[BPScott]

Eeeey it's that old trick.

Leveraging native link behaviour is preferable to me, as this doesn't cover middle-click to open a new tab.

[dleroux]

Should do a check for url because it's not required if there's an onClick.

Also I wonder, if there is an onClick and a URL should the this command click happen first and the onClick be ignored?

[kyledurand]

I figured we should err on the side of caution here and allow the onClick to fire regardless.

[dleroux]

Didn't we used to have a version that overlayed a visually hidden a tag so that you got this behaviour without the nesting?

We render a link if a URL is provided, put it behind the item content and call anchor.click(); after everything we care about in the clicking has occurred.

[dleroux]

Need to update the case where's theres no url and update the unreleased.md. 🎩 looks good, thanks!

[kyledurand]

Thanks for the tophat and comments @dleroux. I've updated this PR

[dleroux]

👍

[ghost]

🎉 Thanks for your contribution to Polaris React!