Fix percy false positives #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
approved these changes
Nov 30, 2018
|
It fixes some issues but the card thing is still broken :( |
|
Haven't had the time to dig into this. Since this change does fix a few examples I'm gonna go ahead and merge it, and address the card popup thing later |
amrocha
force-pushed
the
fix-percy-errors
branch
from
933a48e to
870a81d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Because percy has false positives
WHAT is this pull request doing?
Adds a 2s delay before taking a screenshot
How to 🎩
Run percy a few times locally and make sure the problems that came up because we were taking a scerenshot too fast go away