Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes ToastProps export #722

Merged
merged 4 commits into from Dec 4, 2018

Conversation

@kvendrik
Copy link
Member

commented Dec 4, 2018

WHY are these changes introduced?

fixes issue introduced in 266f129.

WHAT is this pull request doing?

Re-exports ToastProps.

How to 馃帺

Import ToastProps from @shopify/polaris in the playground and make sure it is defined.

@BPScott BPScott temporarily deployed to polaris-react-pr-722 Dec 4, 2018 Inactive

@BPScott BPScott temporarily deployed to polaris-react-pr-722 Dec 4, 2018 Inactive

@BPScott BPScott temporarily deployed to polaris-react-pr-722 Dec 4, 2018 Inactive

@kvendrik kvendrik requested review from amrocha and tmlayton Dec 4, 2018

@amrocha
amrocha approved these changes Dec 4, 2018

@tmlayton tmlayton merged commit f876186 into master Dec 4, 2018

8 checks passed

CLA Contributor License Agreement (CLA) status
Details
WIP ready for review
Details
changelog changelog entry included
Details
ci/circleci: check Your tests passed on CircleCI!
Details
ci/circleci: percy Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 6b914b8...c743911
Details
percy/polaris-react Visual review automatically approved, no visual changes found.
Details
shrink-ray Webpack build report complete :)
Details

@tmlayton tmlayton deleted the fix/toast-props branch Dec 4, 2018

@tmlayton tmlayton deployed to production Dec 5, 2018 Active

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.