Fix several cyclical type imports (redux) #754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the cyclical type import dance.
#691 removes some cyclical imports. It also stopped exporting a few color helper functions in the final build (see #718) as I incorrectly assumed that they should be internal. It turns out people are using them, so that PR got reverted in #721.
This PR is #691 EXCEPT the shuffling of the color helpers (I shall fix those cyclical imports while ensuring they are exported in a follow up PR).
Note that this does not move around any base
Props
interfaces so the styleguide's props explorer is happy with it. (It breaks if you set your componentsProps
as an interface from a different file)WHY are these changes introduced?
Move us closer to enabling the
import/no-cycle
rule by fixing several violations.WHAT is this pull request doing?
Moves some types around to avoid cyclical imports. See #691 for an example of what this means.
How to 🎩
yarn run sk type-check
to prove typescript is happyyarn build-consumer web
then runyarn run sk type-check
in web to prove there are no missing exports (You may have to install polaris-icons in web as a workaround because build-consumer isn't smart enough to handle updating transitive dependencies)yarn build-consumer polaris-styleguide
then runyarn run dev
and check the props explorer for the DataTable, Tabs and ResourceList components still render the same (You may have to install polaris-icons in web as a workaround because build-consumer isn't smart enough to handle updating transitive dependencies)