Add defaults to bleed

[kyledurand]

Bleed should do something by default. This offsets the default horizontal padding from AlphaCard which I think will be the most common use case

Part of #7592

[github-actions]

size-limit report 📦

Path	Size
polaris-react-cjs	209.63 KB (-0.01% 🔽)
polaris-react-esm	136.11 KB (+0.01% 🔺)
polaris-react-esnext	191.26 KB (+0.01% 🔺)
polaris-react-css	41.37 KB (0%)

[laurkim]

💯

[aveline]

Actually I'm not sure this component should have defaults. I realized this PR caused a regression in the Banner which is also using Bleed.

Previous to this change Banner used Bleed this way

<Bleed top="05">
  {headingMarkup}
  {contentMarkup}
</Bleed>

After this change it would need to be updated to

<Bleed top="05" left="0" right="0">

And I don't think that's a great experience for any time Bleed gets used without a left or right prop.

I think we should revert this change.

[kyledurand]

And I don't think that's a great experience for any time Bleed gets used without a left or right prop.

I think that's the lesser used use case though. Feels weird to me to have components that do nothing without adding a configuration. I'm not super tied to these defaults so I'm fine if we decide to revert but it was expected by a user that bleed would have some sort of default

[aveline]

For sure it's ideal when we can have defaults and components can show how they're intended to be used without adding a configuration. But it's a balance and I think it's a worse experience to have to remove default configuration and also having to remove them clutters up the markup.

[kyledurand]

Is there a better default or do you feel like we should remove them completely? If we remove defaults here then what other components shouldn't have a default and why?

Something I've been thinking about is removing all spacing defaults, I don't want to do it but it might be necessary if we remove all zero values from tokens

For now, I'm happy leaving these in but we should definitely come back to this before moving this component out of beta

[aveline]

In the case of Bleed, I think they should be removed completely.

Right now my hunch is more low level components, like Box or Bleed probably don't have a default. They have the most flexibility and are probably used for more varied purposes and so it's harder to land on sensible default. And more opinionated components like Card have defaults or even baked in opinions. They offer less flexibility and if they don't suit the use case, then they can be substituted with the more flexible components. Ex. Box

Something I've been thinking about is removing all spacing defaults

That would probably be a good topic to start a discussion on.