Fix cyclical type imports relating to color-picker helpers

.eslintrc

@@ -49,8 +49,7 @@
     "jsx-a11y/mouse-events-have-key-events": "off",
     "jsx-a11y/click-events-have-key-events": "off",
     "jsx-a11y/no-noninteractive-element-interactions": "off",
-    "jsx-a11y/no-noninteractive-element-to-interactive-role": "off",
-    "import/no-cycle": "off"
+    "jsx-a11y/no-noninteractive-element-to-interactive-role": "off"
   },
   "overrides": [
     {

UNRELEASED.md

@@ -19,6 +19,6 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 ### Development workflow
 
 - Added a slight delay to the Percy screenshot script to give time for components to render fully ([#704](https://github.com/Shopify/polaris-react/pull/704))
-- Refactors to remove cyclical type imports ([#759](https://github.com/Shopify/polaris-react/pull/759) and [#754](https://github.com/Shopify/polaris-react/pull/754))
+- Refactors to remove cyclical type imports ([#759](https://github.com/Shopify/polaris-react/pull/759), [#754](https://github.com/Shopify/polaris-react/pull/754), and [#767](https://github.com/Shopify/polaris-react/pull/767))
 
 ### Dependency upgrades

src/components/ColorPicker/ColorPicker.tsx

@@ -3,7 +3,7 @@ import {clamp} from '@shopify/javascript-utilities/math';
 import {autobind} from '@shopify/javascript-utilities/decorators';
 
 import {hsbToRgb} from '../../utilities/color-transformers';
-import {HSBColor, HSBAColor} from './types';
+import {HSBColor, HSBAColor} from '../../utilities/color-types';
 import {AlphaPicker, HuePicker, Slidable, Position} from './components';
 import * as styles from './ColorPicker.scss';
 

src/components/ColorPicker/components/AlphaPicker/AlphaPicker.tsx

@@ -1,7 +1,7 @@
 import * as React from 'react';
 import {autobind} from '@shopify/javascript-utilities/decorators';
 import Slidable, {Position} from '../Slidable';
-import {HSBColor} from '../../types';
+import {HSBColor} from '../../../../utilities/color-types';
 import {hsbToRgb} from '../../../../utilities/color-transformers';
 import * as styles from '../../ColorPicker.scss';
 import {calculateDraggerY, alphaForDraggerY} from './utilities';

src/components/ColorPicker/index.ts

@@ -1,6 +1,6 @@
 import ColorPicker from './ColorPicker';
 
-export * from './types';
+export * from '../../utilities/color-types';
 export * from '../../utilities/color-transformers';
 
 export {Props} from './ColorPicker';

src/components/ThemeProvider/utils/index.ts

@@ -1,7 +1,7 @@
 import tokens from '@shopify/polaris-tokens';
 import {noop} from '@shopify/javascript-utilities/other';
 import {needsVariantList} from '../config';
-import {HSLColor} from '../../ColorPicker';
+import {HSLColor} from '../../../utilities/color-types';
 import {
   colorToHsla,
   hslToString,

src/utilities/color-manipulation.ts

@@ -1,4 +1,4 @@
-import {HSLColor, HSBColor} from '../components';
+import {HSLColor, HSBColor} from './color-types';
 
 export function lightenColor(color: HSLColor | string, lighten = 0) {
   if (typeof color === 'string') {

src/utilities/color-transformers.ts

@@ -7,7 +7,7 @@ import {
   HSLColor,
   HSLAColor,
   HSBLAColor,
-} from '../components';
+} from './color-types';
 import {compose} from './compose';
 
 export function rgbString(color: RGBColor | RGBAColor) {

src/utilities/color-validation.ts

@@ -1,4 +1,4 @@
-import {RGBColor, RGBAColor} from '../components';
+import {RGBColor, RGBAColor} from './color-types';
 
 // implements: https://www.w3.org/WAI/ER/WD-AERT/#color-contrast
 export function isLight({red, green, blue}: RGBColor | RGBAColor): boolean {

src/utilities/tests/color-manipulation.test.ts

@@ -5,7 +5,7 @@ import {
   createDarkColor,
   createLightColor,
 } from '../color-manipulation';
-import {HSLColor} from '../../components';
+import {HSLColor} from '../color-types';
 
 describe('lightenColor', () => {
   it("will return the color if it's of type string", () => {