Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

[Icon] New icon <diamond_alert_minor> #8063

Merged
merged 3 commits into from
Jan 18, 2023
Merged

[Icon] New icon <diamond_alert_minor> #8063

merged 3 commits into from
Jan 18, 2023

Conversation

eric-blue
Copy link
Contributor

@eric-blue eric-blue commented Jan 17, 2023 •
edited
Loading

WHY are these changes introduced?

closes #8021

created a new icon in the same vein as DiamondAlertMajor

WHAT is this pull request doing?

Adds the svg and yml files for the DiamondAlertMinor icon

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx: 
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@eric-blue eric-blue requested review from KateWood, davidpaulhunt and a team January 17, 2023 19:49
heyjoethomas
heyjoethomas approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@heyjoethomas heyjoethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please also add this to the Figma library as well. Docs for that are on polaris.shopify.com. Feel free to reach out if you have questions.

@eric-blue eric-blue merged commit d5da477 into main Jan 18, 2023
@eric-blue eric-blue deleted the diamond-alert-minor-icon branch January 18, 2023 21:40
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Jan 18, 2023
Merged
mrcthms pushed a commit that referenced this pull request Jan 19, 2023
@shopify-github-actions-access @github-actions
Version Packages (#8065)
0764e1a 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.8.0

### Minor Changes

- [#8049](#8049)
[`dca31f2a0`](dca31f2)
Thanks [@leileu](https://github.com/leileu)! - Added 8 minor icons for
metafields


- [#8069](#8069)
[`f67e2997e`](f67e299)
Thanks [@leileu](https://github.com/leileu)! - Added file minor icon


- [#8063](#8063)
[`d5da4778c`](d5da477)
Thanks [@eric-blue](https://github.com/eric-blue)! - Added minor icon
for diamond_alert


- [#8037](#8037)
[`1aeed2414`](1aeed24)
Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added major and
minor icon for Magic

### Patch Changes

- [#8085](#8085)
[`56b757036`](56b7570)
Thanks [@sarahill](https://github.com/sarahill)! - Added icon name for
magic major and minor


- [#8066](#8066)
[`68acc4593`](68acc45)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added better
error documentation on icon validation

## @shopify/polaris@10.22.0

### Minor Changes

- [#8054](#8054)
[`c44c96c6b`](c44c96c)
Thanks [@mrcthms](https://github.com/mrcthms)! - Update focus states to
be present on :focus-visible rather than :focus

### Patch Changes

- [#8080](#8080)
[`1c926b9da`](1c926b9)
Thanks [@LauraAubin](https://github.com/LauraAubin)! - Added an optional
`zIndexOverride` prop to `Tooltip`


- [#8077](#8077)
[`dc2ed0a5c`](dc2ed0a)
Thanks [@kyledurand](https://github.com/kyledurand)! - Removed data
attribute css from legacy polyfill


- [#8040](#8040)
[`ba6b04c79`](ba6b04c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal
footer vertical alignment when noScroll is true

- Updated dependencies
\[[`dca31f2a0`](dca31f2),
[`56b757036`](56b7570),
[`f67e2997e`](f67e299),
[`68acc4593`](68acc45),
[`d5da4778c`](d5da477),
[`1aeed2414`](1aeed24)]:
    -   @shopify/polaris-icons@6.8.0

## @shopify/plugin-polaris@0.0.29



## polaris.shopify.com@0.29.0

### Minor Changes

- [#8027](#8027)
[`8fc0fefdf`](8fc0fef)
Thanks [@qt314](https://github.com/qt314)! - Add tooling section to
document tools help build and maintain Polaris in consuming
applications.

### Patch Changes

- Updated dependencies
\[[`dca31f2a0`](dca31f2),
[`56b757036`](56b7570),
[`f67e2997e`](f67e299),
[`1c926b9da`](1c926b9),
[`c44c96c6b`](c44c96c),
[`dc2ed0a5c`](dc2ed0a),
[`ba6b04c79`](ba6b04c),
[`68acc4593`](68acc45),
[`d5da4778c`](d5da477),
[`1aeed2414`](1aeed24)]:
    -   @shopify/polaris-icons@6.8.0
    -   @shopify/polaris@10.22.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gwyneplaine gwyneplaine mentioned this pull request Feb 14, 2023
Merged
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@juzser
[Icon] New icon <diamond_alert_minor> (Shopify#8063)
644b92d 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->


### WHY are these changes introduced?

closes Shopify#8021

created a new icon in the same vein as DiamondAlertMajor


### WHAT is this pull request doing?

Adds the svg and yml files for the DiamondAlertMinor icon

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)

<!--
  Give as much information as needed to experiment with the component
  in the playground.
-->

<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>

```jsx
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}
```

</details>

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions @juzser
Version Packages (Shopify#8065)
5723ba7 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-icons@6.8.0

### Minor Changes

- [Shopify#8049](Shopify#8049)
[`dca31f2a0`](Shopify@dca31f2)
Thanks [@leileu](https://github.com/leileu)! - Added 8 minor icons for
metafields


- [Shopify#8069](Shopify#8069)
[`f67e2997e`](Shopify@f67e299)
Thanks [@leileu](https://github.com/leileu)! - Added file minor icon


- [Shopify#8063](Shopify#8063)
[`d5da4778c`](Shopify@d5da477)
Thanks [@eric-blue](https://github.com/eric-blue)! - Added minor icon
for diamond_alert


- [Shopify#8037](Shopify#8037)
[`1aeed2414`](Shopify@1aeed24)
Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added major and
minor icon for Magic

### Patch Changes

- [Shopify#8085](Shopify#8085)
[`56b757036`](Shopify@56b7570)
Thanks [@sarahill](https://github.com/sarahill)! - Added icon name for
magic major and minor


- [Shopify#8066](Shopify#8066)
[`68acc4593`](Shopify@68acc45)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added better
error documentation on icon validation

## @shopify/polaris@10.22.0

### Minor Changes

- [Shopify#8054](Shopify#8054)
[`c44c96c6b`](Shopify@c44c96c)
Thanks [@mrcthms](https://github.com/mrcthms)! - Update focus states to
be present on :focus-visible rather than :focus

### Patch Changes

- [Shopify#8080](Shopify#8080)
[`1c926b9da`](Shopify@1c926b9)
Thanks [@LauraAubin](https://github.com/LauraAubin)! - Added an optional
`zIndexOverride` prop to `Tooltip`


- [Shopify#8077](Shopify#8077)
[`dc2ed0a5c`](Shopify@dc2ed0a)
Thanks [@kyledurand](https://github.com/kyledurand)! - Removed data
attribute css from legacy polyfill


- [Shopify#8040](Shopify#8040)
[`ba6b04c79`](Shopify@ba6b04c)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal
footer vertical alignment when noScroll is true

- Updated dependencies
\[[`dca31f2a0`](Shopify@dca31f2),
[`56b757036`](Shopify@56b7570),
[`f67e2997e`](Shopify@f67e299),
[`68acc4593`](Shopify@68acc45),
[`d5da4778c`](Shopify@d5da477),
[`1aeed2414`](Shopify@1aeed24)]:
    -   @shopify/polaris-icons@6.8.0

## @shopify/plugin-polaris@0.0.29



## polaris.shopify.com@0.29.0

### Minor Changes

- [Shopify#8027](Shopify#8027)
[`8fc0fefdf`](Shopify@8fc0fef)
Thanks [@qt314](https://github.com/qt314)! - Add tooling section to
document tools help build and maintain Polaris in consuming
applications.

### Patch Changes

- Updated dependencies
\[[`dca31f2a0`](Shopify@dca31f2),
[`56b757036`](Shopify@56b7570),
[`f67e2997e`](Shopify@f67e299),
[`1c926b9da`](Shopify@1c926b9),
[`c44c96c6b`](Shopify@c44c96c),
[`dc2ed0a5c`](Shopify@dc2ed0a),
[`ba6b04c79`](Shopify@ba6b04c),
[`68acc4593`](Shopify@68acc45),
[`d5da4778c`](Shopify@d5da477),
[`1aeed2414`](Shopify@1aeed24)]:
    -   @shopify/polaris-icons@6.8.0
    -   @shopify/polaris@10.22.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kencwng kencwng Awaiting requested review from kencwng

@sorta-shopify sorta-shopify Awaiting requested review from sorta-shopify

@antoinegrant antoinegrant Awaiting requested review from antoinegrant

@KateWood KateWood Awaiting requested review from KateWood

@davidpaulhunt davidpaulhunt Awaiting requested review from davidpaulhunt

1 more reviewer

@heyjoethomas heyjoethomas heyjoethomas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Figma UI Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon]: New icon <diamond_alert_minor>
3 participants
@eric-blue @heyjoethomas @flvisi