Skip to content

Use browserslist, remove @shopify/browserslist-config and update caniuse db #8221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 16, 2023
Merged

Use browserslist, remove @shopify/browserslist-config and update caniuse db #8221

merged 8 commits into from
Feb 16, 2023

Conversation

@alex-page
Copy link
Member

@alex-page alex-page commented Jan 31, 2023 •
edited
Loading

WHY are these changes introduced?

We aren't benefitting from using @shopify/browserslist-config as we have to have the config in our repository for our consumers. See #3132 for context.

WHAT is this pull request doing?

  • removes @shopify/browserslist-config
  • installs browserslist as a monorepo devDependency
  • Adds browser support to package.json files that use browserslist
  • Upgrades the caniuse database to latest

@alex-page alex-page changed the title Use browserslist, remove @shopify/browserslist-config and update caniuse… Use browserslist, remove @shopify/browserslist-config and update caniuse db Jan 31, 2023
@alex-page alex-page marked this pull request as ready for review January 31, 2023 05:53
alex-page
alex-page commented Jan 31, 2023
View reviewed changes
BPScott
BPScott requested changes Jan 31, 2023
View reviewed changes
@alex-page alex-page force-pushed the browserslist-update branch from 2e5901b to 3b5d85e Compare February 1, 2023 02:11
@alex-page alex-page requested a review from BPScott February 1, 2023 03:09
@alex-page alex-page self-assigned this Feb 1, 2023
@Shopify Shopify deleted a comment from github-actions bot Feb 2, 2023
@github-actions github-actions bot added cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. and removed cla-needed Added by a bot. Contributor needs to sign the CLA Agreement. labels Feb 3, 2023
@alex-page alex-page force-pushed the browserslist-update branch from 1c6ecae to 3b5d85e Compare February 3, 2023 00:59
@Shopify Shopify deleted a comment from github-actions bot Feb 3, 2023
@Shopify Shopify deleted a comment from github-actions bot Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023 •
edited
Loading

size-limit report 📦

Path Size
polaris-react-cjs 216.05 KB (0%)
polaris-react-esm 138.94 KB (0%)
polaris-react-esnext 194.07 KB (0%)
polaris-react-css 41.88 KB (0%)

@alex-page
Copy link
Member Author

alex-page commented Feb 14, 2023

@BPScott this looks good to me now. Let me know if you have any thoughts.

@alex-page alex-page merged commit 994bb90 into v11-major Feb 16, 2023
@alex-page alex-page deleted the browserslist-update branch February 16, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sam-b-rose sam-b-rose sam-b-rose approved these changes

@BPScott BPScott Awaiting requested review from BPScott

Assignees

@alex-page alex-page

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alex-page @BPScott @sam-b-rose