-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Updates frame layout #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Updates frame layout #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmlayton
reviewed
Jan 18, 2019
tmlayton
reviewed
Jan 18, 2019
tmlayton
reviewed
Jan 18, 2019
tmlayton
reviewed
Jan 18, 2019
tmlayton
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and 🎩 looks good – please squash or rebase into a smaller number of commits before merging though.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Updates the frame layout in light of some soon-to-be-introduced features that will live in the frame. Further details can be found here.
Relies on: #849
Design: https://shopify.invisionapp.com/share/5AP64DZRKZX#/screens/331903554
WHAT is this pull request doing?
TopBar.UserMenu
visible on mobile.Navigation.UserMenu
withTopBar.UserMenu
. Essentially this means thatNavigation.UserMenu
visually doesn't exist anymore but can still be used as any props that you pass into it will be used as props forTopBar.UserMenu
on mobile.border-right
on the side navigation.How to 🎩
yarn dev
, head over to the playground and make sure that:🎩 checklist
Note: ship #887 when this is merged.