Skip to content

[Card] Fix deprecation notice #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[Card] Fix deprecation notice #8523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c92cc8b
chore: fix deprecation notice on card
kyledurand Feb 28, 2023
3df8ab3
Fix test
kyledurand Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/kind-oranges-laugh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed deprecation warning on Card
3 changes: 1 addition & 2 deletions polaris-react/src/components/Card/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export type {
CardSubsectionProps,
} from './components';

/** @deprecated Use LegacyCard or AlphaCard instead. */
export interface CardProps {
/** Title content for the card */
title?: React.ReactNode;
Expand Down Expand Up @@ -48,7 +47,7 @@ export interface CardProps {
// subcomponents so explicitly state the subcomponents in the type definition.
// Letting this be implicit works in this project but fails in projects that use
// generated *.d.ts files.

/** @deprecated Use AlphaCard instead. */
export const Card: React.FunctionComponent<CardProps> & {
// eslint-disable-next-line import/no-deprecated
Header: typeof Header;
Expand Down
3 changes: 3 additions & 0 deletions polaris-react/src/components/Card/tests/Card.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {Button} from '../../Button';
import {Popover} from '../../Popover';
import {ActionList} from '../../ActionList';
import {WithinContentContext} from '../../../utilities/within-content-context';
// eslint-disable-next-line import/no-deprecated
import {Card} from '../Card';
// eslint-disable-next-line import/no-deprecated
import {Section} from '../components';
Expand Down Expand Up @@ -61,6 +62,7 @@ describe('<Card />', () => {
<Card.Header />
</Card>,
);
// eslint-disable-next-line import/no-deprecated
expect(card).toContainReactComponent(Card.Header);
});

Expand All @@ -72,6 +74,7 @@ describe('<Card />', () => {
);

expect(card).toContainReactComponent(Button);
// eslint-disable-next-line import/no-deprecated
expect(card).toContainReactComponent(Card.Header);
});

Expand Down