Skip to content

Fixes ActionList css #8540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Fixes ActionList css #8540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed0cbcc
Fix issue 8459. Made changes for actionlist item use css gap property…
priyankrajai97 Mar 2, 2023
190f58c
Merge branch 'Shopify:main' into main
Ipriyankrajai Mar 2, 2023
c7a4718
Merge branch 'Shopify:main' into main
Ipriyankrajai Mar 4, 2023
1957c58
Update .changeset/flat-masks-sniff.md
chloerice Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/flat-masks-sniff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed `ActionList` item `suffix` having extra padding when wrapped
2 changes: 1 addition & 1 deletion polaris-react/src/components/ActionList/ActionList.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@
// We need the negative margin to ensure that the image does not set
// the minimum height of the action item.
// stylelint-disable -- generated by polaris-migrator DO NOT COPY
margin: calc(-0.5 * var(--pc-action-list-image-size)) var(--p-space-4)
margin: calc(-0.5 * var(--pc-action-list-image-size)) 0
calc(-0.5 * var(--pc-action-list-image-size)) 0;
// stylelint-enable
background-size: cover;
Expand Down
4 changes: 2 additions & 2 deletions polaris-react/src/components/ActionList/components/Item/Item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,15 @@ export function Item({
);

const suffixMarkup = suffix && (
<Box paddingInlineStart="4">
<Box>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can Box be removed completely now?

Copy link
Contributor Author

@Ipriyankrajai Ipriyankrajai Mar 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @kyledurand, we can remove Box as Suffix is already wrapped in span.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kyledurand, I made changes as you suggested. Added a commit and pushed it to the main branch(i.e. same branch I created pr). But for some reason, I'm unable to see my commit here. Can you help me with this issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a new pull request for this change? That will run all the necessary checks including chromatic and make sure we don't cause any visual regressions

<span className={styles.Suffix}>{suffix}</span>
</Box>
);

const textMarkup = <span className={styles.Text}>{contentMarkup}</span>;

const contentElement = (
<Inline blockAlign="center">
<Inline blockAlign="center" gap="4">
{prefixMarkup}
{textMarkup}
{badgeMarkup}
Expand Down