Skip to content

[Frame] Fix min-height for iOS browsers (#8590) #8596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023
Merged

[Frame] Fix min-height for iOS browsers (#8590) #8596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/two-swans-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': minor
---

[Frame] Fix minimum height overflowing in iOS Webkit browsers
1 change: 1 addition & 0 deletions polaris-react/src/components/Frame/Frame.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
--pc-frame-button-size: var(--p-space-8);
width: 100%;
min-height: 100vh;
min-height: 100svh; // For mobile browsers, fill the screen taking into account dynamic browser chrome
Comment on lines 7 to +8

This comment was marked as resolved.

Sign in to view

Copy link
Member

@chloerice chloerice Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ah ignore me, dvh is too unstable)

display: flex;
background-color: var(--p-color-bg-app);

Expand Down