revert [Banner] [Card] [Modal] convert banner legacy context API to use create context #786 #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrosenthal
changed the title
danrosenthal
added
the
🤖Skip Changelog
BPScott
approved these changes
Jan 16, 2019
danrosenthal
force-pushed
the
reexport-content-context-types
branch
from
f1b94a9 to
8b9c7e4
Compare
dleroux
approved these changes
Jan 16, 2019
dleroux
reviewed
Jan 16, 2019
danrosenthal
force-pushed
the
reexport-content-context-types
branch
from
8b9c7e4 to
b4bc27b
Compare
danrosenthal
force-pushed
the
reexport-content-context-types
branch
from
b4bc27b to
c179989
Compare
danrosenthal
force-pushed
the
reexport-content-context-types
branch
from
c179989 to
bfb3be5
Compare
danrosenthal
force-pushed
the
reexport-content-context-types
branch
from
bfb3be5 to
32d0c4f
Compare
danrosenthal
removed
the
🤖Skip Changelog
danrosenthal
commented
Jan 16, 2019
dleroux
reviewed
Jan 16, 2019
danrosenthal
force-pushed
the
reexport-content-context-types
branch
from
32d0c4f to
9121b5d
Compare
This reverts commit 26d4af3.
danrosenthal
changed the title
BPScott
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there is a fork of Card in web that relied on those contextTypes being exported, and updates to use new React context should really be considered a breaking change. This reverts all of #786 to avoid breaking changes.
See https://buildkite.com/shopify/web-ci-builder/builds/39489 and https://github.com/Shopify/web/pull/9824 for more context.