Skip to content

[Tabs] pressed state fix #8990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2023
Merged

[Tabs] pressed state fix #8990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c59e0b
Update Tabs interactive states
heyjoethomas Apr 17, 2023
203185d
Create healthy-emus-pump.md
heyjoethomas Apr 17, 2023
6fe4e63
Update .changeset/healthy-emus-pump.md
alex-page Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-emus-pump.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Update tokens for border of `Tabs` on hover and pressed state to create better quality interaction.
4 changes: 2 additions & 2 deletions polaris-react/src/components/Tabs/Tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ $item-vertical-padding: $item-min-height * 0.5;
background-color: transparent;
// stylelint-disable-next-line selector-max-specificity -- generated by polaris-migrator DO NOT COPY
&::before {
background-color: var(--p-color-border-hover);
background-color: var(--p-color-bg-strong-hover);
}
}
}
Expand All @@ -73,7 +73,7 @@ $item-vertical-padding: $item-min-height * 0.5;
background-color: transparent;
// stylelint-disable-next-line selector-max-specificity -- generated by polaris-migrator DO NOT COPY
&::before {
background: var(--p-color-bg-primary-subdued-active);
background-color: var(--p-color-bg-strong-active);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion polaris-react/src/components/Tag/Tag.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ $button-size: 20px;
}

&:active {
background: var(--p-color-bg-strong-active);
background: var(--p-color-bg-strong-hover);
}

&:disabled {
Expand Down