Skip to content

🚧 WIP Link update #9077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

🚧 WIP Link update #9077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
693c1a4
Update `Link` component
aveline Apr 24, 2023
c41348e
Add `language` prop to `Link`
aveline Apr 25, 2023
b7a544c
Update `Link` prop
aveline Apr 25, 2023
b448e44
Update `tone` value for `Link`
aveline Apr 25, 2023
42e26cb
Update `Link` prop
aveline Apr 25, 2023
9ae7ca1
Update `Link` stories
aveline Apr 27, 2023
af0cacc
Merge branch 'main' into link-update
aveline Apr 27, 2023
169c0ee
Update Select.stories.tsx
aveline Apr 27, 2023
52d279c
Update Select.stories.tsx
aveline Apr 27, 2023
0cf0168
Update styleguide `Link` examples
aveline Apr 27, 2023
8973caf
Update more styleguide `Link` examples
aveline Apr 27, 2023
edede87
Update link-external.tsx
aveline Apr 27, 2023
1735f45
Merge branch 'main' into link-update
aveline Apr 27, 2023
10d1f36
Merge branch 'main' into link-update
aveline Apr 28, 2023
ba541ca
Update Link.test.tsx
aveline Apr 28, 2023
be186d5
🙈
aveline Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions polaris-react/src/components/AccountConnection/AccountConnection.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ export function Default() {
const terms = connected ? null : (
<p>
By clicking <strong>Connect</strong>, you agree to accept Sample App’s{' '}
<Link url="Example App">terms and conditions</Link>. You’ll pay a
commission rate of 15% on sales made through Sample App.
<Link href="Example App" underline="always">
terms and conditions
</Link>
. You’ll pay a commission rate of 15% on sales made through Sample App.
</p>
);

Expand Down
17 changes: 12 additions & 5 deletions polaris-react/src/components/Banner/Banner.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ export function Dismissible() {
<Banner onDismiss={() => {}}>
<p>
Use your finance report to get detailed information about your business.{' '}
<Link url="">Let us know what you think</Link>
<Link underline="always" tone="inherit" href="">
Let us know what you think
</Link>
</p>
</Banner>
);
Expand Down Expand Up @@ -104,8 +106,10 @@ export function Critical() {
>
<p>
Before fulfilling this order or capturing payment, please{' '}
<Link url="">review the Risk Analysis</Link> and determine if this order
is fraudulent.
<Link underline="always" tone="inherit" href="">
review the Risk Analysis
</Link>{' '}
and determine if this order is fraudulent.
</p>
</Banner>
);
Expand Down Expand Up @@ -180,7 +184,10 @@ export function InACard() {
<Banner onDismiss={() => {}}>
<p>
Use your finance report to get detailed information about your
business. <Link url="">Let us know what you think</Link>
business.{' '}
<Link underline="always" tone="inherit" href="">
Let us know what you think
</Link>
</p>
</Banner>

Expand All @@ -198,7 +205,7 @@ export function WithEndJustifiedContent() {
<Text variant="headingMd" fontWeight="semibold" as="h3">
Deployment failed in 5min
</Text>
<Link external url="https://example.com">
<Link tone="inherit" href="https://example.com" target="_blank">
Logs
</Link>
</HorizontalStack>
Expand Down
2 changes: 1 addition & 1 deletion polaris-react/src/components/Collapsible/Collapsible.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function Default() {
have shown an interest in your store. Reach out to them with
exclusive offers or updates about your products.
</p>
<Link url="#">Test link</Link>
<Link href="#">Test link</Link>
</TextContainer>
</Collapsible>
</LegacyStack>
Expand Down
Loading