-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Link] iteration #9185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Link] iteration #9185
Conversation
size-limit report 📦
|
chazdean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! I like the CSS approach in Banner ✨
|
/snapit |
|
🫰✨ Thanks @aveline! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230515155511yarn add @shopify/polaris-codemods@0.0.0-snapshot-release-20230515155511yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230515155511yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230515155511yarn add @shopify/polaris@0.0.0-snapshot-release-20230515155511yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230515155511yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230515155511 |
chloerice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @aveline! We'll need to revert removing the external prop and deprecate instead.
| /** Makes the link open in a new tab */ | ||
| external?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prop will need to be deprecated first and then we can remove it in v12.
| /** Makes the link open in a new tab */ | |
| external?: boolean; | |
| /** | |
| ** @deprecated Set `target` to "_blank" instead | |
| ** Makes the link open in a new tab | |
| */ | |
| external?: boolean; |
|
Closing for #9223 |
WHY are these changes introduced?
Fixes #8794 #8797
WHAT is this pull request doing?
BannerContextfromLinkcomponentexternalprop fromLinkcomponentHow to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes