Skip to content

Conversation

@aveline
Copy link
Contributor

@aveline aveline commented May 10, 2023

WHY are these changes introduced?

Fixes #8794 #8797

WHAT is this pull request doing?

  • Removes BannerContext from Link component
  • Removed external prop from Link component

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

Copy-paste this code in playground/Playground.tsx:
import React from 'react';
import {Page} from '../src';

export function Playground() {
  return (
    <Page title="Playground">
      {/* Add the code you want to test in here */}
    </Page>
  );
}

🎩 checklist

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2023

size-limit report 📦

Path Size
polaris-react-cjs 242.89 KB (0%)
polaris-react-esm 157.14 KB (-0.04% 🔽)
polaris-react-esnext 219.69 KB (+0.02% 🔺)
polaris-react-css 47.5 KB (+0.12% 🔺)

@aveline aveline requested a review from chazdean May 10, 2023 21:11
@aveline aveline added the #gsd:32613 Button and Link component quality label May 10, 2023
Copy link
Contributor

@chazdean chazdean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! I like the CSS approach in Banner ✨

@aveline aveline marked this pull request as ready for review May 12, 2023 21:33
@aveline aveline changed the title 🚧 WIP [Link] iteration [Link] iteration May 12, 2023
@aveline aveline mentioned this pull request May 12, 2023
3 tasks
@aveline
Copy link
Contributor Author

aveline commented May 15, 2023

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aveline! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230515155511
yarn add @shopify/polaris-codemods@0.0.0-snapshot-release-20230515155511
yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20230515155511
yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230515155511
yarn add @shopify/polaris@0.0.0-snapshot-release-20230515155511
yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230515155511
yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230515155511

@aveline aveline requested review from alex-page and chloerice May 15, 2023 20:07
Copy link
Member

@chloerice chloerice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @aveline! We'll need to revert removing the external prop and deprecate instead.

Comment on lines -17 to -18
/** Makes the link open in a new tab */
external?: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prop will need to be deprecated first and then we can remove it in v12.

Suggested change
/** Makes the link open in a new tab */
external?: boolean;
/**
** @deprecated Set `target` to "_blank" instead
** Makes the link open in a new tab
*/
external?: boolean;

@aveline
Copy link
Contributor Author

aveline commented May 16, 2023

Closing for #9223

@aveline aveline closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:32613 Button and Link component quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Button and Link quality] [Milestone 1] Update Link component

3 participants