Skip to content

Deprecate external prop in Link component #9223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 2, 2023
Merged

Deprecate external prop in Link component #9223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e2ccb6
Deprecate `external` prop in `Link` component
aveline May 16, 2023
8e9ae9f
Update Link.tsx
aveline May 16, 2023
c3fdb58
Merge branch 'main' into link-deprecate-external
aveline Jun 2, 2023
cac6412
changeset
aveline Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-cycles-invent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Deprecated `external` prop in `Link` component
4 changes: 3 additions & 1 deletion polaris-react/src/components/Link/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ export interface LinkProps {
url?: string;
/** The content to display inside the link */
children?: React.ReactNode;
/** Makes the link open in a new tab */
/** Makes the link open in a new tab
* @deprecated use `target` set to `_blank` instead
*/
external?: boolean;
/** Where to display the url */
target?: Target;
Expand Down