Tabs (formerly AlphaTabs) disabled tabs on an individual level #9229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
aeperea
force-pushed
the
alphatab-disabled
branch
from
515f132 to
790a75b
Compare
Member
|
Hey @aeperea 👋🏽 Thanks for fixing this! We're shipping v11.0.0 this week, so we're blocking changes to components that change in v11 until after it ships. AlphaTabs is moving to stable in v11, so once the release is out we can ship this change. |
Member
|
As @chloerice said above if we want to ship this asap we need to create a fix in two places. One in |
aeperea
force-pushed
the
alphatab-disabled
branch
from
790a75b to
7f3ff5d
Compare
aeperea
changed the title
Member
|
v11 is in |
alex-page
approved these changes
May 31, 2023
Merged
alex-page
pushed a commit
that referenced
this pull request
Jun 5, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.1.0 ### Minor Changes - [#9269](#9269) [`bf3bc75a1`](bf3bc75) Thanks [@nat-king](https://github.com/nat-king)! - Added optional `onAddFilterClick` callback prop to the indexFilters component ### Patch Changes - [#9295](#9295) [`7e21fe093`](7e21fe0) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `initials` overflowing when `Avatar` is round - [#9343](#9343) [`ae3208332`](ae32083) Thanks [@qt314](https://github.com/qt314)! - Alphabetized locale files - [#9314](#9314) [`e7d836819`](e7d8368) Thanks [@FCalabria](https://github.com/FCalabria)! - Removed focus styles on TextField while disabled - [#9223](#9223) [`221426aaf`](221426a) Thanks [@aveline](https://github.com/aveline)! - Deprecated `external` prop in `Link` component - [#9229](#9229) [`821535820`](8215358) Thanks [@aeperea](https://github.com/aeperea)! - Tabs update disabled state - [#9323](#9323) [`cd43c8b47`](cd43c8b) Thanks [@qt314](https://github.com/qt314)! - Added internationalized accessibility label to Banner dismiss button - [#9263](#9263) [`a3f3462a6`](a3f3462) Thanks [@mattkubej](https://github.com/mattkubej)! - Protect border radius of `LegacyCard` with overflow clip - [#9273](#9273) [`e823538ad`](e823538) Thanks [@aishad](https://github.com/aishad)! - Fixed inline padding on Modal Footer ## @shopify/polaris-cli@0.2.2 ## polaris.shopify.com@0.55.0 ### Minor Changes - [#9311](#9311) [`b6f2d7928`](b6f2d79) Thanks [@lgriffee](https://github.com/lgriffee)! - Created a "What's new" page for v11 token changes. ### Patch Changes - [#8840](#8840) [`a7569b7f5`](a7569b7) Thanks [@alex-page](https://github.com/alex-page)! - Updated Colors page with v11 content - Updated dependencies \[[`7e21fe093`](7e21fe0), [`ae3208332`](ae32083), [`e7d836819`](e7d8368), [`221426aaf`](221426a), [`821535820`](8215358), [`cd43c8b47`](cd43c8b), [`a3f3462a6`](a3f3462), [`e823538ad`](e823538), [`bf3bc75a1`](bf3bc75)]: - @shopify/polaris@11.1.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
…fy#9229) ### WHY are these changes introduced? When working on https://github.com/Shopify/core-issues/issues/53313, noticed the previous **LegacyTabs** doesn't support disabled state for tabs. **Tabs** does, but the props from the individual tab are not passed to the component that actually disables it. ### WHAT is this pull request doing? We make sure that the optional prop for the tab (with structure TabProps) for disabled state gets passed along to the markup. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.1.0 ### Minor Changes - [Shopify#9269](Shopify#9269) [`bf3bc75a1`](Shopify@bf3bc75) Thanks [@nat-king](https://github.com/nat-king)! - Added optional `onAddFilterClick` callback prop to the indexFilters component ### Patch Changes - [Shopify#9295](Shopify#9295) [`7e21fe093`](Shopify@7e21fe0) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `initials` overflowing when `Avatar` is round - [Shopify#9343](Shopify#9343) [`ae3208332`](Shopify@ae32083) Thanks [@qt314](https://github.com/qt314)! - Alphabetized locale files - [Shopify#9314](Shopify#9314) [`e7d836819`](Shopify@e7d8368) Thanks [@FCalabria](https://github.com/FCalabria)! - Removed focus styles on TextField while disabled - [Shopify#9223](Shopify#9223) [`221426aaf`](Shopify@221426a) Thanks [@aveline](https://github.com/aveline)! - Deprecated `external` prop in `Link` component - [Shopify#9229](Shopify#9229) [`821535820`](Shopify@8215358) Thanks [@aeperea](https://github.com/aeperea)! - Tabs update disabled state - [Shopify#9323](Shopify#9323) [`cd43c8b47`](Shopify@cd43c8b) Thanks [@qt314](https://github.com/qt314)! - Added internationalized accessibility label to Banner dismiss button - [Shopify#9263](Shopify#9263) [`a3f3462a6`](Shopify@a3f3462) Thanks [@mattkubej](https://github.com/mattkubej)! - Protect border radius of `LegacyCard` with overflow clip - [Shopify#9273](Shopify#9273) [`e823538ad`](Shopify@e823538) Thanks [@aishad](https://github.com/aishad)! - Fixed inline padding on Modal Footer ## @shopify/polaris-cli@0.2.2 ## polaris.shopify.com@0.55.0 ### Minor Changes - [Shopify#9311](Shopify#9311) [`b6f2d7928`](Shopify@b6f2d79) Thanks [@lgriffee](https://github.com/lgriffee)! - Created a "What's new" page for v11 token changes. ### Patch Changes - [Shopify#8840](Shopify#8840) [`a7569b7f5`](Shopify@a7569b7) Thanks [@alex-page](https://github.com/alex-page)! - Updated Colors page with v11 content - Updated dependencies \[[`7e21fe093`](Shopify@7e21fe0), [`ae3208332`](Shopify@ae32083), [`e7d836819`](Shopify@e7d8368), [`221426aaf`](Shopify@221426a), [`821535820`](Shopify@8215358), [`cd43c8b47`](Shopify@cd43c8b), [`a3f3462a6`](Shopify@a3f3462), [`e823538ad`](Shopify@e823538), [`bf3bc75a1`](Shopify@bf3bc75)]: - @shopify/polaris@11.1.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
…fy#9229) ### WHY are these changes introduced? When working on https://github.com/Shopify/core-issues/issues/53313, noticed the previous **LegacyTabs** doesn't support disabled state for tabs. **Tabs** does, but the props from the individual tab are not passed to the component that actually disables it. ### WHAT is this pull request doing? We make sure that the optional prop for the tab (with structure TabProps) for disabled state gets passed along to the markup. ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@11.1.0 ### Minor Changes - [Shopify#9269](Shopify#9269) [`bf3bc75a1`](Shopify@4c4ea3f) Thanks [@nat-king](https://github.com/nat-king)! - Added optional `onAddFilterClick` callback prop to the indexFilters component ### Patch Changes - [Shopify#9295](Shopify#9295) [`7e21fe093`](Shopify@1e6866e) Thanks [@chloerice](https://github.com/chloerice)! - Fixed `initials` overflowing when `Avatar` is round - [Shopify#9343](Shopify#9343) [`ae3208332`](Shopify@8e37127) Thanks [@qt314](https://github.com/qt314)! - Alphabetized locale files - [Shopify#9314](Shopify#9314) [`e7d836819`](Shopify@77a0b7f) Thanks [@FCalabria](https://github.com/FCalabria)! - Removed focus styles on TextField while disabled - [Shopify#9223](Shopify#9223) [`221426aaf`](Shopify@7a8633b) Thanks [@aveline](https://github.com/aveline)! - Deprecated `external` prop in `Link` component - [Shopify#9229](Shopify#9229) [`821535820`](Shopify@b3044bb) Thanks [@aeperea](https://github.com/aeperea)! - Tabs update disabled state - [Shopify#9323](Shopify#9323) [`cd43c8b47`](Shopify@6069404) Thanks [@qt314](https://github.com/qt314)! - Added internationalized accessibility label to Banner dismiss button - [Shopify#9263](Shopify#9263) [`a3f3462a6`](Shopify@813bf03) Thanks [@mattkubej](https://github.com/mattkubej)! - Protect border radius of `LegacyCard` with overflow clip - [Shopify#9273](Shopify#9273) [`e823538ad`](Shopify@4cc79bb) Thanks [@aishad](https://github.com/aishad)! - Fixed inline padding on Modal Footer ## @shopify/polaris-cli@0.2.2 ## polaris.shopify.com@0.55.0 ### Minor Changes - [Shopify#9311](Shopify#9311) [`b6f2d7928`](Shopify@7ddf98f) Thanks [@lgriffee](https://github.com/lgriffee)! - Created a "What's new" page for v11 token changes. ### Patch Changes - [Shopify#8840](Shopify#8840) [`a7569b7f5`](Shopify@7f0860a) Thanks [@alex-page](https://github.com/alex-page)! - Updated Colors page with v11 content - Updated dependencies \[[`7e21fe093`](Shopify@1e6866e), [`ae3208332`](Shopify@8e37127), [`e7d836819`](Shopify@77a0b7f), [`221426aaf`](Shopify@7a8633b), [`821535820`](Shopify@b3044bb), [`cd43c8b47`](Shopify@6069404), [`a3f3462a6`](Shopify@813bf03), [`e823538ad`](Shopify@4cc79bb), [`bf3bc75a1`](Shopify@4c4ea3f)]: - @shopify/polaris@11.1.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When working on https://github.com/Shopify/core-issues/issues/53313, noticed the previous LegacyTabs doesn't support disabled state for tabs. Tabs does, but the props from the individual tab are not passed to the component that actually disables it.
WHAT is this pull request doing?
We make sure that the optional prop for the tab (with structure TabProps) for disabled state gets passed along to the markup.
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes